[GitHub] [kafka] wcarlson5 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

[GitBox]

wcarlson5 commented on a change in pull request #9614:
URL: https://github.com/apache/kafka/pull/9614#discussion_r526352796



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java
##########
@@ -377,7 +378,7 @@ private void shouldAddMetricsOnAllLevels(final String 
builtInMetricsVersion) thr
             builtInMetricsVersion
         );
         checkCacheMetrics(builtInMetricsVersion);
-
+        verifyFailedStreamThreadsSensor(0.0);

Review comment:
       I think you should try using the custom processor. You can find an 
example in `StreamsUncaughtExceptionHandlerIntegrationTest.java`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org