ijuma commented on a change in pull request #9435:
URL: https://github.com/apache/kafka/pull/9435#discussion_r526911200
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -1333,7 +1343,17 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
- val completeTopicMetadata = topicMetadata ++
unauthorizedForCreateTopicMetadata ++ unauthorizedForDescribeTopicMetadata
+ val completeTopicMetadata = (if (metadataRequest.isAllTopics) {
Review comment:
This is a good point. We should pass a boolean to `getTopicMetadata`
indicating that it's an "allTopics" request and have that method handle
everything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
