cadonna commented on a change in pull request #9648:
URL: https://github.com/apache/kafka/pull/9648#discussion_r529846543
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java
##########
@@ -149,24 +149,30 @@ public boolean hasPersistentGlobalStore() {
return false;
}
- public void updateSourceTopics(final Map<String, List<String>>
sourceTopicsByName) {
- if (!sourceTopicsByName.keySet().equals(sourceNodesByName.keySet())) {
- log.error("Set of source nodes do not match: \n" +
- "sourceNodesByName = {}\n" +
- "sourceTopicsByName = {}",
- sourceNodesByName.keySet(), sourceTopicsByName.keySet());
- throw new IllegalStateException("Tried to update source topics but
source nodes did not match");
- }
+ public void updateSourceTopics(final Map<String, List<String>>
allSourceTopicsByNodeName) {
Review comment:
The scope of an integration test and of a unit test are quite different.
The integration test specifically tests the pattern subscription whereas the
unit test just tests the update of the source topics. Probably at the moment
the update of the source topics is only called when pattern subscription is
used, but that assumption seems rather brittle to me because it may change in
future. I think that neither of the tests is useless. If one were useless, I
would keep the unit test for test execution performance reasons.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
