[GitHub] [kafka] rohitrmd commented on a change in pull request #9660: Kafka 10629 - TopologyTestDriver should not require a Properties argument

[GitBox]

rohitrmd commented on a change in pull request #9660:
URL: https://github.com/apache/kafka/pull/9660#discussion_r532103737



##########
File path: streams/src/test/java/org/apache/kafka/streams/TopologyTest.java
##########
@@ -353,8 +349,7 @@ public void shouldThrowOnUnassignedStateStoreAccess() {
             .addProcessor(badNodeName, new LocalMockProcessorSupplier(), 
sourceNodeName);
 
         try {
-            new TopologyTestDriver(topology, mkProperties(
-                mkMap(mkEntry(StreamsConfig.STATE_DIR_CONFIG, 
TestUtils.tempDirectory().getAbsolutePath()))));
+            new TopologyTestDriver(topology);

Review comment:
       That's a good point. This test is validating if exception is thrown when 
topology is created with processor node which doesn't have state store 
specified. Providing STATE_DIR_CONFIG config parameter in properties won't 
alter desired outcome of the test. Hence I removed it. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org