jsancio commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r534476673
##########
File path: clients/src/main/resources/common/message/LeaderChangeMessage.json
##########
@@ -22,7 +22,11 @@
{"name": "LeaderId", "type": "int32", "versions": "0+",
"about": "The ID of the newly elected leader"},
{"name": "Voters", "type": "[]Voter", "versions": "0+",
- "about": "The voters who voted for the current leader"}
+ "about": "The set of voters in the quorum for this epoch"},
+ {"name": "GrantingVoters", "type": "[]Voter", "versions": "0+",
+ "about": "The voters who voted for the leader at the time of election"},
+ {"name": "LeaderEpoch", "type": "int32", "versions": "0+",
Review comment:
To me the question that we need to answer is if we want this messages to
be self contained. Meaning do we only need to have this message to know the
state of the election or leader change. Or do we also need to know where in the
log this message was inserted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
