splett2 commented on a change in pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#discussion_r535397962
##########
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##########
@@ -56,11 +56,12 @@ import scala.collection._
* --entity-type users --entity-name <user-principal>
--entity-type clients --entity-name <client-id>
* <li> broker: --broker <broker-id> OR --entity-type brokers
--entity-name <broker-id>
* <li> broker-logger: --broker-logger <broker-id> OR --entity-type
broker-loggers --entity-name <broker-id>
+ * <li> ip: --IP <ip> OR --entity-type IPs --entity-name <ip>
* </ul>
- * --entity-type <users|clients|brokers> --entity-default may be specified in
place of --entity-type <users|clients|brokers> --entity-name <entityName>
- * when describing or altering default configuration for users, clients, or
brokers, respectively.
- * Alternatively, --user-defaults, --client-defaults, or --broker-defaults may
be specified in place of
- * --entity-type <users|clients|brokers> --entity-default, respectively.
+ * --entity-type <users|clients|brokers|IPs> --entity-default may be specified
in place of --entity-type <users|clients|brokers|IPs> --entity-name <entityName>
+ * when describing or altering default configuration for users, clients,
brokers, or IPs, respectively.
+ * Alternatively, --user-defaults, --client-defaults, --broker-defaults, or
--IP-defaults may be specified in place of
Review comment:
@dajac
it was originally lower-case in #9386
after reading the KIP, i realized it was described as being upper case, e.g.
```
Default quota for <IPs> will be stored in Zookeeper at /config/IPs/<default>
Quota for a specific IP address for which quota override is defined will be
stored in Zookeeper at /config/IPs/<ip-address>
```
and changed it to upper in this PR with the change in
```
core/src/main/scala/kafka/server/DynamicConfigManager.scala
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
