hachikuji commented on a change in pull request #9564:
URL: https://github.com/apache/kafka/pull/9564#discussion_r537786674
##########
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala
##########
@@ -208,7 +209,9 @@ class BrokerToControllerRequestThread(networkClient:
KafkaClient,
}
private[server] def handleResponse(request:
BrokerToControllerQueueItem)(response: ClientResponse): Unit = {
- if (response.wasDisconnected()) {
+ if (isTimedOut(response)) {
+ debug(s"The request failed to send to the controller after timeout
${clientRequestTimeout} ms: $response")
+ } else if (response.wasDisconnected()) {
Review comment:
Note that we handle authentication exceptions in
`InterBrokerSendThread`. We log a message and mark the response as
"disconnected." I think it is reasonable to keep retrying in case the broker's
configuration changes and so that the error messages will remain persistent in
the logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
