mjsax commented on a change in pull request #9688:
URL: https://github.com/apache/kafka/pull/9688#discussion_r538926128
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java
##########
@@ -540,18 +535,18 @@ public void shouldUpgradeFromEosAlphaToEosBeta() throws
Exception {
}
// 7. only for crash case:
- // 7a. restart the second client in eos-alpha mode and wait
until rebalance stabilizes
+ // 7a. restart the failed second client in eos-alpha mode and
wait until rebalance stabilizes
// 7b. write third batch of input data
// * fail the first (i.e., eos-beta) client during commit
// * the eos-alpha client should not pickup the pending
offsets
// * verify uncommitted and committed result
// 7c. restart the first client in eos-beta mode and wait
until rebalance stabilizes
//
// crash case:
- // p-0: 10 rec + C + 4 rec + A + 5 rec + C + 5 rec + C ---> 10
rec + A + 10 rec + C
- // p-1: 10 rec + C + 5 rec + A + 5 rec + C + 5 rec + C ---> 10
rec + A + 10 rec + C
- // p-2: 10 rec + C + 5 rec + C + 5 rec + A + 5 rec + C ---> 10
rec + C
- // p-3: 10 rec + C + 5 rec + C + 5 rec + A + 5 rec + C ---> 10
rec + C
+ // p-0: 10 rec + C + 4 rec + A + 5 rec + C + 5 rec + C --->
10 rec + A + 10 rec + C
Review comment:
Yes. I wanted to improve the readability of the comment -- the
additional blanks separate the the main phases of the test (each main phase
write 10 records per partition that should eventually be committed).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
