kowshik opened a new pull request #9718: URL: https://github.com/apache/kafka/pull/9718
I have fixed what looked like a potential bug to me. From within `Log.updateProducers(…)`, the code operates on the `producerStateManager` attribute of the `Log` object (see [this](https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/log/Log.scala#L1464) where we call `producerStateManager.prepareUpdate`). This looks unusual particularly for `Log.loadProducersFromLog(...)` path. For this path I believe we should be updating the producers into the instance passed to it, rather than the one in the `Log` object attribute. I have fixed the same in this PR. **Tests:** Rely on existing tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
