ijuma commented on pull request #9435: URL: https://github.com/apache/kafka/pull/9435#issuecomment-741597240
@chia7712 The code changes seen fine. The comment in KafkaApis still seems a bit convoluted. For example, not returning UnknownTopicOrPartition is not related to backwards compatibility, it doesn't make sense to return that if the given topic wasn't explicitly requested. Similarly, the fact that allowAutoTopicCreation is true for some clients isn't that relevant, the code needs to handle it irrespective of what some clients do or don't do. I thought my suggested comment in the following was clear and concise, but I'm interested in other opinions: https://github.com/apache/kafka/pull/9435#discussion_r535321971 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
