mumrah commented on a change in pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#discussion_r539437410
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -98,6 +97,7 @@ import scala.annotation.nowarn
* Logic to handle the various Kafka requests
*/
class KafkaApis(val requestChannel: RequestChannel,
+ val apisUtils: ApisUtils,
Review comment:
1. Agreed. I don't really like the name, but can't think of a better one.
2. Originally, I had hoped to remove some dependencies from KafkaApis when
pulling out these methods, but it turns out they are all needed for other
things as well. In the end it just adds a new dependency (which is fine).
Seeing how I had to mess around with the type hierarchy to not break or
complicate TestRaftRequestHandler, I'm leaning towards the delegation approach
we had before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
