vvcephei commented on a change in pull request #9697:
URL: https://github.com/apache/kafka/pull/9697#discussion_r541028355
##########
File path:
streams/src/main/java/org/apache/kafka/streams/errors/StreamsUncaughtExceptionHandler.java
##########
@@ -27,6 +27,7 @@
* Enumeration that describes the response from the exception handler.
*/
enum StreamThreadExceptionResponse {
+ REPLACE_THREAD(0, "REPLACE_STREAM_THREAD"),
Review comment:
Oh, good catch.
Just a quick question: did we misname this option in the KIP? A StreamThread
is a specific kind of thread. What I mean is that a GlobalStreamThread is _not_
a StreamThread. Perhaps `REPLACE_THREAD` and `SHUTDOWN_THREAD` would have been
better, more general names, for these. If you agree, I think we can just amend
the KIP and fix it in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
