hachikuji commented on a change in pull request #9732:
URL: https://github.com/apache/kafka/pull/9732#discussion_r541158744
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/AddOffsetsToTxnRequest.java
##########
@@ -53,7 +53,7 @@ public AddOffsetsToTxnRequest(AddOffsetsToTxnRequestData
data, short version) {
}
@Override
- protected AddOffsetsToTxnRequestData data() {
+ public AddOffsetsToTxnRequestData data() {
Review comment:
Yeah, not sure it's worth it, though I don't feel strongly. I think
ultimately we're going to start relying more on the generated classes to avoid
unnecessary conversions. We're now entering "phase 2" of the request overhaul
which means we can start figuring out how to remove the
AbstractRequest/AbstractResponse layer. I think it will take more smarts in the
generated classes to make a dent here, but if we are agreed on the goal (?),
then I do not think preserving the encapsulation here is worthwhile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
