[GitHub] [kafka] ijuma commented on a change in pull request #9747: KAFKA-10852: AlterIsr should be a cluster action

[GitBox]

ijuma commented on a change in pull request #9747:
URL: https://github.com/apache/kafka/pull/9747#discussion_r542452727



##########
File path: 
clients/src/test/java/org/apache/kafka/common/protocol/ApiKeysTest.java
##########
@@ -55,11 +61,14 @@ public void schemaVersionOutOfRange() {
      */
     @Test
     public void testResponseThrottleTime() {
-        List<ApiKeys> authenticationKeys = 
Arrays.asList(ApiKeys.SASL_HANDSHAKE, ApiKeys.SASL_AUTHENTICATE);
+        Set<ApiKeys> authenticationKeys = EnumSet.of(ApiKeys.SASL_HANDSHAKE, 
ApiKeys.SASL_AUTHENTICATE);
+        // Newer protocol apis include throttle time ms even for cluster 
actions
+        Set<ApiKeys> clusterActionsWithThrottleTimeMs = 
EnumSet.of(ApiKeys.ALTER_ISR);

Review comment:
       We have to decide whether we want to do this or remove the throttle time 
ms from AlterIsr before 2.7.0.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org