ijuma commented on a change in pull request #9748:
URL: https://github.com/apache/kafka/pull/9748#discussion_r543816097
##########
File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
##########
@@ -361,69 +172,35 @@ private static boolean
shouldRetainsBufferReference(Schema[] requestSchemas) {
}
public static ApiKeys forId(int id) {
Review comment:
We used `int` here because `short` in Java is a second class citizen and
casting is required in some cases. If we decide to change this, a separate PR
(as you suggested) would be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
