[ 
https://issues.apache.org/jira/browse/KAFKA-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250249#comment-17250249
 ] 

Sagar Rao commented on KAFKA-10788:
-----------------------------------

Sure [~guozhang].

[~rohitdeshaws] here is the pr comment for your reference: 
[https://github.com/apache/kafka/pull/9508#discussion_r527599966]

The idea is to mock the `underlyingStore` field instead of creating an instance 
of it. MeteredKeyValueStoreTest already does something like this. 

> Streamlining Tests in CachingInMemoryKeyValueStoreTest
> ------------------------------------------------------
>
>                 Key: KAFKA-10788
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10788
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams, unit tests
>            Reporter: Sagar Rao
>            Assignee: Rohit Deshpande
>            Priority: Major
>              Labels: newbie
>
> While reviewing, kIP-614, it was decided that tests for 
> [CachingInMemoryKeyValueStoreTest.java|https://github.com/apache/kafka/pull/9508/files/899b79781d3412658293b918dce16709121accf1#diff-fdfe70d8fa0798642f0ed54785624aa9850d5d86afff2285acdf12f2775c3588]
>  need to be streamlined to use mocked underlyingStore.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to