[GitHub] [kafka] Montyleo commented on pull request #9675: KAFKA-10794 Replica leader election is too slow in the case of too many partitions

[GitBox]

Montyleo commented on pull request #9675:
URL: https://github.com/apache/kafka/pull/9675#issuecomment-747942928


   > @chia7712 does the patch can resolve the issue ? I find the only 
differences is that controllerContext.allPartitions can be invoked once or the 
number of partition times . please correct me if I am wrong. thanks.
   
   Hi，lqjack
   
   Thanks for your question.
   There is a saying that: quantitative change leads to qualitative change.
   when  the function controllerContext.allPartitions was called too many time, 
the rebalance will become too slow.
   I'll show you the effect after the PR published，1.3ms VS 35541ms
   
   
![clipboard_image_1608279734070](https://user-images.githubusercontent.com/8037560/102591724-723fc080-414d-11eb-84ed-c3e1ca704f8c.png)
   
   
![image](https://user-images.githubusercontent.com/8037560/102591822-9ac7ba80-414d-11eb-9a15-e01b6b261892.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org