jsancio commented on a change in pull request #9553:
URL: https://github.com/apache/kafka/pull/9553#discussion_r547483452
##########
File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java
##########
@@ -287,4 +287,7 @@ public String name() {
return "Leader";
}
+ @Override
+ public void close() {}
Review comment:
I prefer to have each of the epoch states explicitly opt out of this
`close` method. This makes it clear that this state doesn't have any resource
that it wishes to clean/close during a transition. Instead of future code
changes forgetting to override this method. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
