rohitrmd commented on pull request #9744:
URL: https://github.com/apache/kafka/pull/9744#issuecomment-751068878


   @mjsax made following changes to the pr:
   
   1. Got rid of 
[currentSystemTimeMs](https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java#L48)
 from AbstractProcessorContext, that in effect required changing other 
[GloblaProcessorContextImpl](https://github.com/apache/kafka/pull/9744/files#diff-66f1420c00b334fbe657e3a2c6fb5f8bcd60407dd7f87d9ed6bb1365958e01e4R121)
 to return current system time.  This was needed because of 
[this](https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/SourceNode.java#L87).
 MockProcessorContext and MockInternalProcessorContext also required similar 
changes. 
   2. In StreamTask, had to add the method to set system 
[time](https://github.com/apache/kafka/pull/9744/files#diff-a76674468cda8772230fb8411717cf9068b1a363a792f32c602fb2ec5ba9efd7R1127)
 for test purposes only. As we are getting wall clock time from StreamTask now 
instead of ProcessorContext, this change was needed for these 
[tests](https://github.com/apache/kafka/pull/9744/files#diff-d2d5426c1d8b525415735ad409e82d4ff34ea3712a8217e4a99b421e470d4c19R497-R547).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to