itantiger commented on a change in pull request #8753:
URL: https://github.com/apache/kafka/pull/8753#discussion_r549113162
##########
File path: core/src/main/scala/kafka/tools/ConsumerPerformance.scala
##########
@@ -271,13 +271,22 @@ object ConsumerPerformance extends LazyLogging {
val brokerHostsAndPorts = options.valueOf(if
(options.has(bootstrapServerOpt)) bootstrapServerOpt else brokerListOpt)
props.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, brokerHostsAndPorts)
- props.put(ConsumerConfig.GROUP_ID_CONFIG, options.valueOf(groupIdOpt))
- props.put(ConsumerConfig.RECEIVE_BUFFER_CONFIG,
options.valueOf(socketBufferSizeOpt).toString)
- props.put(ConsumerConfig.MAX_PARTITION_FETCH_BYTES_CONFIG,
options.valueOf(fetchSizeOpt).toString)
- props.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, if
(options.has(resetBeginningOffsetOpt)) "latest" else "earliest")
- props.put(ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG,
classOf[ByteArrayDeserializer])
- props.put(ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG,
classOf[ByteArrayDeserializer])
- props.put(ConsumerConfig.CHECK_CRCS_CONFIG, "false")
+ if (props.getProperty(ConsumerConfig.GROUP_ID_CONFIG) == null)
Review comment:
Hi @chia7712 This is my first submission, use `props.putIfAbsent` is
better, but i dont what should do next？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
