showuon commented on a change in pull request #9789:
URL: https://github.com/apache/kafka/pull/9789#discussion_r549561892
##########
File path: core/src/main/scala/kafka/network/SocketServer.scala
##########
@@ -988,60 +990,79 @@ private[kafka] class Processor(val id: Int,
}
}
+ protected def isControlRequest(header: RequestHeader): Boolean = {
+ if (isControlPlane) {
+ header.apiKey() match {
+ case ApiKeys.LEADER_AND_ISR => true
+ case ApiKeys.STOP_REPLICA => true
+ case ApiKeys.UPDATE_METADATA => true
+ case ApiKeys.CONTROLLED_SHUTDOWN => true
+ case _ => false
+ }
+ }else {
Review comment:
Not sure if this is better=:
```scala
header.apiKey() match {
case ApiKeys.LEADER_AND_ISR | ApiKeys.STOP_REPLICA | ... | ... if
(isControlPlane) => true
case _ => false
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
