hachikuji commented on pull request #9781: URL: https://github.com/apache/kafka/pull/9781#issuecomment-752188121
@chia7712 Since this is a new api, I think we are free to choose its error semantics. I agree that there is some inconsistency between different APIs, but we are often stuck with that because a top-level error code didn't come until later (e.g. see `FetchResponse`). The benefit of having a top-level error is that we do not need to propagate it. See `AlterIsr` for a similar example. Also note the handling logic in `KafkaApis.handleUpdateFeatures` which already relies on this approach: https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L3222. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
