[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

[GitBox]

jolshan commented on a change in pull request #9684:
URL: https://github.com/apache/kafka/pull/9684#discussion_r550905081



##########
File path: clients/src/main/resources/common/message/DeleteTopicsRequest.json
##########
@@ -23,10 +23,17 @@
   //
   // Version 5 adds ErrorMessage in the response and may return a 
THROTTLING_QUOTA_EXCEEDED error
   // in the response if the topics deletion is throttled (KIP-599).
-  "validVersions": "0-5",
+  //
+  // Version 6 reorganizes topics, adds topic IDs and allows topic names to be 
null.
+  "validVersions": "0-6",
   "flexibleVersions": "4+",
   "fields": [
-    { "name": "TopicNames", "type": "[]string", "versions": "0+", 
"entityType": "topicName",
+    { "name": "Topics", "type": "[]DeleteTopicState", "versions": "6+", 
"about": "The name or topic ID of the topic",
+      "fields": [
+        {"name": "Name", "type": "string", "versions": "6+", 
"nullableVersions": "6+", "about": "The topic name"},

Review comment:
       We will use the zero UUID to represent null as described in the KIP.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org