chia7712 commented on a change in pull request #9728:
URL: https://github.com/apache/kafka/pull/9728#discussion_r552051062
##########
File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala
##########
@@ -680,4 +681,31 @@ class LogManagerTest {
time.sleep(logConfig.fileDeleteDelayMs + 1)
verifyMetrics(1)
}
+
+ @Test
+ def testWaitForAllToComplete(): Unit = {
+ var invokedCount = 0
+ val success: Future[Boolean] = Mockito.mock(classOf[Future[Boolean]])
+ Mockito.when(success.get()).thenAnswer(_ => invokedCount += 1)
Review comment:
```waitForAllToComplete``` does not use the return value so it does not
cause casting error even though we don't return ```true```. However, it does
look like a bug so I will add the return value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
