mjsax commented on a change in pull request #9720:
URL: https://github.com/apache/kafka/pull/9720#discussion_r553027410



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java
##########
@@ -174,8 +177,8 @@ private KafkaStreams buildStreamWithDirtyStateDir(final 
String stateDirPath,
     }
 
     @Test
-    @Deprecated
     public void shouldWipeOutStandbyStateDirectoryIfCheckpointIsMissing() 
throws Exception {
+        final long time = System.currentTimeMillis();

Review comment:
       I see. You are talking about the broker side log cleaner thread -- not 
the local state directory cleaner thread. (windowed stores also use the concept 
of segments, not just topic-partitions).
   
   However, it seems we want to extract this fix into a separate PR to be able 
to cherry-pick it to older branches? Seems to be unrelated to this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to