wcarlson5 commented on a change in pull request #9695:
URL: https://github.com/apache/kafka/pull/9695#discussion_r553490127
##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -1432,7 +1480,9 @@ public void cleanUp() {
validateIsRunningOrRebalancing();
final Set<ThreadMetadata> threadMetadata = new HashSet<>();
for (final StreamThread thread : threads) {
- threadMetadata.add(thread.threadMetadata());
+ if (thread.state() != StreamThread.State.DEAD) {
+ threadMetadata.add(thread.threadMetadata());
+ }
}
return threadMetadata;
Review comment:
`changeThreadCount ` would not take care of that we need to sync on the
thread state
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
