gharris1727 commented on pull request #9806: URL: https://github.com/apache/kafka/pull/9806#issuecomment-756853770
> Presumably, if some client application is using the JVM-global JAAS config, it's because it wants to pick up on mutations to that config. ...in the case of the basic auth REST extension, we don't really want to do that, and so we shouldn't rely on that global mutable state in the first place. This is a very interesting way to look at this coordination, and I think is very helpful. I see that I'm falling into the trap of assuming that _every_ static shared resource is a bug waiting to happen, because i've only ever seen bugs result from them. This is surely confirmation bias, and i'm sure there's legitimate use-cases for this coordination that I just haven't seen because they aren't broken 😃. There is an argument to be made that this is just an isolation leak, and that such code is relying on a bug, but there's clearly a debate to be had from both sides. None of this discussion has anything to do with this fix directly, and I think it's a step in the right direction regardless. LGTM! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
