jolshan commented on a change in pull request #9814: URL: https://github.com/apache/kafka/pull/9814#discussion_r554599936
########## File path: core/src/main/scala/kafka/zk/AdminZkClient.scala ########## @@ -153,16 +157,17 @@ class AdminZkClient(zkClient: KafkaZkClient) extends Logging { LogConfig.validate(config) } - private def writeTopicPartitionAssignment(topic: String, replicaAssignment: Map[Int, ReplicaAssignment], isUpdate: Boolean): Unit = { + private def writeTopicPartitionAssignment(topic: String, replicaAssignment: Map[Int, ReplicaAssignment], + isUpdate: Boolean, usesTopicId: Boolean = false): Unit = { Review comment: Some places that eventually call this do not have access to IBP. The controller will eventually pick up and assign topic IDs that need them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org