mjsax commented on a change in pull request #9744:
URL: https://github.com/apache/kafka/pull/9744#discussion_r556207831
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java
##########
@@ -45,7 +45,6 @@
private boolean initialized;
protected ProcessorRecordContext recordContext;
protected ProcessorNode<?, ?, ?, ?> currentNode;
- private long currentSystemTimeMs;
Review comment:
@guozhangwang -- I am just wondering if removing this variable (what I
think conceptually makes sense) might have an perf impact as it seems
`currentSystemTimeMs` acts as some kind of cache -- and instead of using the
cached time, we would call `time.currentTimeMillis()` in
`ProcessorContextImpl#forwardInternal()` now.
Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
