[GitHub] [kafka] chia7712 commented on a change in pull request #9874: KAFKA-7340: Migrate clients module to JUnit 5

[GitBox]

chia7712 commented on a change in pull request #9874:
URL: https://github.com/apache/kafka/pull/9874#discussion_r556632806



##########
File path: clients/src/test/java/org/apache/kafka/clients/admin/ConfigTest.java
##########
@@ -18,77 +18,64 @@
 package org.apache.kafka.clients.admin;
 
 import org.apache.kafka.clients.admin.ConfigEntry.ConfigType;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
-import java.util.ArrayList;
-import java.util.Collection;
 import java.util.List;
 
-import static org.hamcrest.CoreMatchers.containsString;
-import static org.hamcrest.CoreMatchers.equalTo;
-import static org.hamcrest.CoreMatchers.hasItems;
-import static org.hamcrest.CoreMatchers.is;
-import static org.hamcrest.CoreMatchers.not;
-import static org.hamcrest.CoreMatchers.nullValue;
-import static org.hamcrest.MatcherAssert.assertThat;
+import static java.util.Arrays.asList;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 public class ConfigTest {
     private static final ConfigEntry E1 = new ConfigEntry("a", "b");
     private static final ConfigEntry E2 = new ConfigEntry("c", "d");
     private Config config;
 
-    @Before
+    @BeforeEach
     public void setUp() {
-        final Collection<ConfigEntry> entries = new ArrayList<>();
-        entries.add(E1);
-        entries.add(E2);
-
-        config = new Config(entries);
+        config = new Config(asList(E1, E2));
     }
 
     @Test
     public void shouldGetEntry() {
-        assertThat(config.get("a"), is(E1));
-        assertThat(config.get("c"), is(E2));
+        assertEquals(E1, config.get("a"));
+        assertEquals(E2, config.get("c"));
     }
 
     @Test
     public void shouldReturnNullOnGetUnknownEntry() {
-        assertThat(config.get("unknown"), is(nullValue()));
+        assertNull(config.get("unknown"));
     }
 
     @Test
     public void shouldGetAllEntries() {
-        assertThat(config.entries().size(), is(2));
-        assertThat(config.entries(), hasItems(E1, E2));
+        assertEquals(2, config.entries().size());
+        assertTrue(config.entries().contains(E1));
+        assertTrue(config.entries().contains(E2));
     }
 
     @Test
     public void shouldImplementEqualsProperly() {
-        final Collection<ConfigEntry> entries = new ArrayList<>();
-        entries.add(E1);
-
-        assertThat(config, is(equalTo(config)));
-        assertThat(config, is(equalTo(new Config(config.entries()))));
-        assertThat(config, is(not(equalTo(new Config(entries)))));
-        assertThat(config, is(not(equalTo((Object) "this"))));
+        assertEquals(config, config);
+        assertEquals(config, new Config(config.entries()));
+        assertNotEquals(new Config(asList(E1)), config);
+        assertNotEquals("this", config);

Review comment:
       The assert aimed to verify ```config.equal("this")``` so ```config``` 
should be in first argument.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org