dengziming edited a comment on pull request #9819: URL: https://github.com/apache/kafka/pull/9819#issuecomment-761348665
> [comment](https://github.com/apache/kafka/pull/9819#issuecomment-761119104) I have tried locally to replace the FileRegion with FileRecords, and it worked fine, which means that "aligned on offsets" is just a soft requirement of `FetchRequest`, the `MemoryRecords` from `FetchResponse` is not necessarily be aligned, so it's viable to use `FileRecords` and `MemoryRecords` to implement zero-copy, the only additional work is to support `BaseRecords.writeTo(FileChannel)` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
