g1geordie commented on a change in pull request #9926:
URL: https://github.com/apache/kafka/pull/9926#discussion_r559736097
##########
File path: generator/src/test/java/org/apache/kafka/message/EntityTypeTest.java
##########
@@ -17,15 +17,13 @@
package org.apache.kafka.message;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.Timeout;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Timeout;
-import static org.junit.Assert.fail;
+import static org.junit.jupiter.api.Assertions.fail;
Review comment:
same as @chia7712 said .
if you can use assertThrows to replace expectException . awesome
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
