ijuma commented on a change in pull request #9746:
URL: https://github.com/apache/kafka/pull/9746#discussion_r559916570
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java
##########
@@ -220,4 +217,16 @@ private static FinalizedFeatureKeyCollection
createFinalizedFeatureKeys(
return converted;
}
+
+ public static Optional<ApiVersionsResponseData.ApiVersion>
intersect(ApiVersionsResponseData.ApiVersion thisVersion,
+
ApiVersionsResponseData.ApiVersion other) {
+ if (other == null) return Optional.empty();
Review comment:
That's not a good way to design apis, right? This kind of thing should
be symmetric. Why is `other` sometimes `null`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
