guozhangwang commented on a change in pull request #9640:
URL: https://github.com/apache/kafka/pull/9640#discussion_r559928371
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java
##########
@@ -53,16 +56,17 @@
private final Map<TopicPartition, String> ownedPartitions = new
TreeMap<>(TOPIC_PARTITION_COMPARATOR);
private final Map<String, Set<TaskId>> consumerToPreviousStatefulTaskIds =
new TreeMap<>();
- // the following four maps are used only for logging purposes;
- // TODO KAFKA-10283: we could consider merging them with other
book-keeping maps at client-levels
- // so that they would not be inconsistent
Review comment:
@ableegoldman yes you're right. On the high-level I want to consolidate
sets that *always* get updated at the same time, since it is vulnerable to bugs
when we forget to update some of them while modifying the others. But for maps
that are logically orthogonal (i.e. they are not always updated at the same
time) then we could still keep them separated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
