aloknnikhil commented on a change in pull request #9916:
URL: https://github.com/apache/kafka/pull/9916#discussion_r560611932
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1687,6 +1714,15 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:
Boolean, dynamicConfigO
val deleteTopicEnable = getBoolean(KafkaConfig.DeleteTopicEnableProp)
def compressionType = getString(KafkaConfig.CompressionTypeProp)
+ /** ********* Raft Quorum Configuration *********/
+ val quorumVoters = getString(KafkaConfig.QuorumVotersProp)
Review comment:
Spoke offline. The ClusterTestKit on the `kip-500` branch currently
requires the `quorum.voters` to be empty at startup and to be set at a later
point-in-time (once the controller starts and has chosen a free port). We don't
want testing to dictate the norm here. So, to allow for that one alternative is
to add a `skipVoterValidation` flag in a later PR. For now, I'll move the
validation from RaftConfig to KafkaConfig and skip the validation if the voter
string is empty
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
