dajac commented on a change in pull request #9938:
URL: https://github.com/apache/kafka/pull/9938#discussion_r561681627
##########
File path:
core/src/test/scala/integration/kafka/api/DescribeAuthorizedOperationsTest.scala
##########
@@ -73,11 +114,6 @@ class DescribeAuthorizedOperationsTest extends
IntegrationTestHarness with SaslS
TestUtils.waitUntilBrokerMetadataIsPropagated(servers)
}
- private def accessControlEntry(userName: String, permissionType:
AclPermissionType, operation: AclOperation): AccessControlEntry = {
- new AccessControlEntry(new KafkaPrincipal(KafkaPrincipal.USER_TYPE,
userName).toString,
- AclEntry.WildcardHost, operation, permissionType)
- }
-
@AfterEach
override def tearDown(): Unit = {
if (client != null)
Review comment:
I think that it is better to keep it as `client` could not be
initialized. For instance, let's say that there is an exception raised when the
client is constructed. In this case, `client` would remain `null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
