vvcephei commented on a change in pull request #9840:
URL: https://github.com/apache/kafka/pull/9840#discussion_r562090811



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -910,6 +900,11 @@ public void addRecords(final TopicPartition partition, 
final Iterable<ConsumerRe
         }
     }
 
+    @Override
+    public void addFetchedMetadata(final TopicPartition partition, final 
ConsumerRecords.Metadata metadata) {

Review comment:
       Wouldn't it be good to avoid taking on unrelated refactoring TODOs in 
this PR? It seems better to me to leave it to whoever decides to pick up that 
TODO and instead just keep this PR focused on the feature.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to