wilkinsona commented on a change in pull request #9947:
URL: https://github.com/apache/kafka/pull/9947#discussion_r562467953
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java
##########
@@ -115,22 +115,29 @@ public void shouldCreateBaseDirectory() {
@Test
public void shouldHaveSecurePermissions() {
- final Set<PosixFilePermission> expectedPermissions = EnumSet.of(
- PosixFilePermission.OWNER_EXECUTE,
- PosixFilePermission.GROUP_READ,
- PosixFilePermission.OWNER_WRITE,
- PosixFilePermission.GROUP_EXECUTE,
- PosixFilePermission.OWNER_READ);
-
- final Path statePath = Paths.get(stateDir.getPath());
- final Path basePath = Paths.get(appDir.getPath());
- try {
- final Set<PosixFilePermission> baseFilePermissions =
Files.getPosixFilePermissions(statePath);
- final Set<PosixFilePermission> appFilePermissions =
Files.getPosixFilePermissions(basePath);
- assertThat(expectedPermissions, equalTo(baseFilePermissions));
- assertThat(expectedPermissions, equalTo(appFilePermissions));
- } catch (final IOException e) {
- fail("Should create correct files and set correct permissions");
+ assertPermissions(Paths.get(stateDir.getPath()));
+ assertPermissions(Paths.get(appDir.getPath()));
+ }
+
+ private void assertPermissions(final Path path) {
+ if
(path.getFileSystem().supportedFileAttributeViews().contains("posix")) {
+ final Set<PosixFilePermission> expectedPermissions = EnumSet.of(
+ PosixFilePermission.OWNER_EXECUTE,
+ PosixFilePermission.GROUP_READ,
+ PosixFilePermission.OWNER_WRITE,
+ PosixFilePermission.GROUP_EXECUTE,
+ PosixFilePermission.OWNER_READ);
+ try {
+ final Set<PosixFilePermission> baseFilePermissions =
Files.getPosixFilePermissions(path);
Review comment:
`filePermissions` sounds good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
