vvcephei commented on pull request #9836: URL: https://github.com/apache/kafka/pull/9836#issuecomment-765574234
Thanks @guozhangwang , I considered that, but I think for this work, we actually do want to return the metadata if we have fetched some. Since the semantics of `poll(timeout)` are that it will wait _up to_ the timeout to return and that it may or may not return any records, it seems this PR's behavior is just fine. All that is wrong is that this particular test expects to get records back after a single poll. Among our integration tests, this is a pretty unique expectation, so I felt good about relaxing it. Does that seem ok to you? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
