chia7712 commented on a change in pull request #9960:
URL: https://github.com/apache/kafka/pull/9960#discussion_r563481973



##########
File path: 
clients/src/main/java/org/apache/kafka/common/security/authenticator/DefaultKafkaPrincipalBuilder.java
##########
@@ -188,9 +185,7 @@ public KafkaPrincipal deserialize(byte[] bytes) {
             throw new SerializationException("Invalid principal data version " 
+ version);

Review comment:
       Could we use ```HIGHEST_SUPPORTED_VERSION``` and 
```LOWEST_SUPPORTED_VERSION``` to replace origin condition ("0" and 
```DefaultPrincipalData.SCHEMAS.length```) ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to