kkonstantine commented on a change in pull request #9805:
URL: https://github.com/apache/kafka/pull/9805#discussion_r563487426
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java
##########
@@ -50,7 +50,6 @@
* to workers.
*/
public class WorkerCoordinator extends AbstractCoordinator implements
Closeable {
- // Currently doesn't support multiple task assignment strategies, so we
just fill in a default value
public static final String DEFAULT_SUBPROTOCOL = "default";
Review comment:
The definition has moved into:
https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/ConnectProtocolCompatibility.java#L45
We should use `EAGER.protocol()` to replace the usage of this member field
variable and then remove it.
##########
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java
##########
@@ -105,7 +106,7 @@
@Parameters
public static Iterable<?> mode() {
return Arrays.asList(new Object[][]{
- {ConnectProtocolCompatibility.EAGER, 1},
+ {EAGER, 1},
{ConnectProtocolCompatibility.COMPATIBLE, 2}});
Review comment:
If you change the line above, then let's change this one too and fix the
asymmetry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
