jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r564243248
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -370,7 +375,9 @@ class Log(@volatile private var _dir: File,
throw new KafkaStorageException(s"The memory mapped buffer for log of
$topicPartition is already closed")
}
- def highWatermark: Long = highWatermarkMetadata.messageOffset
+ def highWatermark: Long = _highWatermarkMetadata.messageOffset
+
+ def highWatermarkMetadata: LogOffsetMetadata = _highWatermarkMetadata
Review comment:
Yeah. Good point. I changed it to use `fetchOffsetSnapshot`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
