jolshan commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r564639774
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -1194,9 +1194,13 @@ class KafkaApis(val requestChannel: RequestChannel,
// Check if topicId is presented firstly.
val topicIds = metadataRequest.topicIds.asScala.toSet.filterNot(_ ==
Uuid.ZERO_UUID)
- val supportedVersionTopicIds = if (config.interBrokerProtocolVersion >=
KAFKA_2_8_IV1) topicIds else Set.empty[Uuid]
- val unsupportedVersionTopicIds = topicIds.diff(supportedVersionTopicIds)
+ val (supportedVersionTopicIds, unsupportedVersionTopicIds) = if
(config.interBrokerProtocolVersion >= KAFKA_2_8_IV1)
+ (topicIds, Set.empty[Uuid])
+ else
+ (Set.empty[Uuid], topicIds)
+
+ // val unsupportedVersionTopicIds = topicIds.diff(supportedVersionTopicIds)
Review comment:
nit: remove commented out line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
