chia7712 commented on a change in pull request #10017:
URL: https://github.com/apache/kafka/pull/10017#discussion_r568403080
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
##########
@@ -1948,7 +1948,7 @@ public OffsetAndMetadata committed(TopicPartition
partition, final Duration time
Timer timer = time.timer(timeout);
Map<String, List<PartitionInfo>> topicMetadata =
fetcher.getTopicMetadata(
new
MetadataRequest.Builder(Collections.singletonList(topic),
metadata.allowAutoTopicCreation()), timer);
- return topicMetadata.get(topic);
+ return topicMetadata.getOrDefault(topic, Collections.emptyList());
Review comment:
just curious.
Is it possible that an existent topic has no partitions? If so, returning
empty list may confuse users who querying nonexistent topic. Maybe we should
throw ```UnknownTopicOrPartitionException``` for nonexistent topic and return
empty list for existent topic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
