rondagostino commented on a change in pull request #10008:
URL: https://github.com/apache/kafka/pull/10008#discussion_r569433906
##########
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala
##########
@@ -96,7 +94,8 @@ class TransactionStateManager(brokerId: Int,
private[transaction] val transactionMetadataCache: mutable.Map[Int,
TxnMetadataCacheEntry] = mutable.Map()
/** number of partitions for the transaction log topic */
- private val transactionTopicPartitionCount =
getTransactionTopicPartitionCount
+ private var retrieveTransactionTopicPartitionCount: () => Int = _
+ private var transactionTopicPartitionCount: Int = _
Review comment:
Same question here about `@volatile`. The value is set once at startup
and is used in a denominator within `partitionFor()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
