vvcephei commented on a change in pull request #10022:
URL: https://github.com/apache/kafka/pull/10022#discussion_r569581763
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
##########
@@ -1236,7 +1236,7 @@ public void assign(Collection<TopicPartition> partitions)
{
}
final FetchedRecords<K, V> records = pollForFetches(timer);
- if (!records.isEmpty()) {
+ if (!records.records().isEmpty()) {
Review comment:
Thanks, all. I agree with the conclusion that the system is operating as
designed, so we should close this PR and either change the design or the system
tests.
I also think @rajinisivaram 's suggestion to discuss it on the mailing list
is a good one, so that the discussion will be part of the history of the KIP
and not lost to the sands of time in this thread.
I'll send a new response to the vote thread to re-initialize that discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
