cmccabe commented on a change in pull request #10019:
URL: https://github.com/apache/kafka/pull/10019#discussion_r569617960
##########
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##########
@@ -936,7 +939,10 @@ class DynamicListenerConfig(server: KafkaServer) extends
BrokerReconfigurable wi
if (listenersAdded.nonEmpty)
server.socketServer.addListeners(listenersAdded)
- server.kafkaController.updateBrokerInfo(server.createBrokerInfo)
+ server match {
+ case kafkaServer: KafkaServer =>
kafkaServer.kafkaController.updateBrokerInfo(kafkaServer.createBrokerInfo)
+ case _ =>
Review comment:
We should have a KafkaServer method for changing the configuration.
In ZK mode it will have to update the broker info in the old controller.
In KIP-500 mode it will re-register with the controller quorum.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
