cmccabe commented on a change in pull request #10030: URL: https://github.com/apache/kafka/pull/10030#discussion_r569806358
########## File path: metadata/src/test/java/org/apache/kafka/queue/KafkaEventQueueTest.java ########## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.queue; + +import java.util.Arrays; +import java.util.List; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ExecutionException; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.concurrent.atomic.AtomicLong; +import java.util.function.Supplier; +import org.apache.kafka.common.errors.TimeoutException; +import org.apache.kafka.common.utils.LogContext; +import org.apache.kafka.common.utils.MockTime; +import org.apache.kafka.common.utils.Time; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.Timeout; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertThrows; + + +@Timeout(value = 60) +public class KafkaEventQueueTest { + private static class FutureEvent<T> implements EventQueue.Event { + private final CompletableFuture<T> future; + private final Supplier<T> supplier; + + FutureEvent(CompletableFuture<T> future, Supplier<T> supplier) { + this.future = future; + this.supplier = supplier; + } + + @Override + public void run() throws Exception { + T value = supplier.get(); + future.complete(value); + } + + @Override + public void handleException(Throwable e) { + future.completeExceptionally(e); + } + } + + @Test + public void testCreateAndClose() throws Exception { + KafkaEventQueue queue = + new KafkaEventQueue(Time.SYSTEM, new LogContext(), "testCreateAndClose"); + queue.close(); + } + + @Test + public void testHandleEvents() throws Exception { + KafkaEventQueue queue = + new KafkaEventQueue(Time.SYSTEM, new LogContext(), "testHandleEvents"); + AtomicInteger numEventsExecuted = new AtomicInteger(0); + CompletableFuture<Integer> future1 = new CompletableFuture<>(); + queue.prepend(new FutureEvent<>(future1, () -> { + assertEquals(1, numEventsExecuted.incrementAndGet()); + return 1; + })); + CompletableFuture<Integer> future2 = new CompletableFuture<>(); + queue.appendWithDeadline(Time.SYSTEM.nanoseconds() + TimeUnit.SECONDS.toNanos(30), Review comment: I will enlarge the timeout to 60 seconds so that it's equal to the test timeout as a whole. Assuming that timeout is reasonable (and I think it is) then there should be no issue... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
