vamossagar12 commented on a change in pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#discussion_r570153122
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStore.java
##########
@@ -103,6 +105,20 @@ public void putAll(final List<KeyValue<Bytes, byte[]>>
entries) {
}
}
+ @Override
+ public <PS extends Serializer<P>, P> KeyValueIterator<Bytes, byte[]>
prefixScan(final P prefix, final PS prefixKeySerializer) {
Review comment:
Here is the new ticket:
https://issues.apache.org/jira/browse/KAFKA-12289 and the PR for the ticket:
https://github.com/apache/kafka/pull/10052
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingKeyValueStore.java
##########
@@ -291,6 +292,16 @@ public void putAll(final List<KeyValue<Bytes, byte[]>>
entries) {
return new MergedSortedCacheKeyValueBytesStoreIterator(cacheIterator,
storeIterator, true);
}
+ @Override
+ public <PS extends Serializer<P>, P> KeyValueIterator<Bytes, byte[]>
prefixScan(final P prefix, final PS prefixKeySerializer) {
Review comment:
Actually, I had created another ticket to streamline tests for
CachingKVStore: https://issues.apache.org/jira/browse/KAFKA-10788. @rohitrmd
had volunteered to take this up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
