showuon commented on a change in pull request #10002:
URL: https://github.com/apache/kafka/pull/10002#discussion_r571361102



##########
File path: docs/security.html
##########
@@ -649,22 +649,22 @@ <h3 class="anchor-heading"><a id="security_sasl" 
class="anchor-link"></a><a href
         <li><h5 class="anchor-heading"><a 
id="security_sasl_plain_brokerconfig" class="anchor-link"></a><a 
href="#security_sasl_plain_brokerconfig">Configuring Kafka Brokers</a></h5>
             <ol>
             <li>Add a suitably modified JAAS file similar to the one below to 
each Kafka broker's config directory, let's call it kafka_server_jaas.conf for 
this example:
-                <pre class="line-numbers"><code class="language-text">        
KafkaServer {
-            org.apache.kafka.common.security.plain.PlainLoginModule required
-            username="admin"
-            password="admin-secret"
-            user_admin="admin-secret"
-            user_alice="alice-secret";
-        };</code></pre>
+                <pre class="line-numbers"><code 
class="language-text">KafkaServer {
+    org.apache.kafka.common.security.plain.PlainLoginModule required
+    username="admin"
+    password="admin-secret"
+    user_admin="admin-secret"
+    user_alice="alice-secret";
+};</code></pre>
                 This configuration defines two users (<i>admin</i> and 
<i>alice</i>). The properties <tt>username</tt> and <tt>password</tt>
                 in the <tt>KafkaServer</tt> section are used by the broker to 
initiate connections to other brokers. In this example,
                 <i>admin</i> is the user for inter-broker communication. The 
set of properties <tt>user_<i>userName</i></tt> defines
                 the passwords for all users that connect to the broker and the 
broker validates all client connections including
                 those from other brokers using these properties.</li>
             <li>Pass the JAAS config file location as JVM parameter to each 
Kafka broker:
-                <pre>    
-Djava.security.auth.login.config=/etc/kafka/kafka_server_jaas.conf</code></pre></li>
+                
<pre>-Djava.security.auth.login.config=/etc/kafka/kafka_server_jaas.conf</code></pre></li>
             <li>Configure SASL port and SASL mechanisms in server.properties 
as described <a href="#security_sasl_brokerconfig">here</a>. For example:
-                <pre>    listeners=SASL_SSL://host.name:port
+                <pre>listeners=SASL_SSL://host.name:port

Review comment:
       Wow, I've reviewed it twice but didn't found it! Thanks for pointing 
out. Updated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to